Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constructTimeZone in store/mockstore/mockcopr #47577

Closed
YangKeao opened this issue Oct 12, 2023 · 0 comments · Fixed by #47578
Closed

Remove constructTimeZone in store/mockstore/mockcopr #47577

YangKeao opened this issue Oct 12, 2023 · 0 comments · Fixed by #47578
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

Enhancement

constructTimeZone is just a redirection of timeutil.ConstructTimeZone. We should move the test cases and the function.
@YangKeao YangKeao added the type/enhancement The issue or PR belongs to an enhancement. label Oct 12, 2023
@YangKeao YangKeao mentioned this issue Oct 12, 2023
Merged
5 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 12, 2023
@YangKeao
mockcopr: remove the constructTimeZone function (#47578)
14d3cb5 
close #47577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mockcopr: remove the constructTimeZone function YangKeao/tidb
1 participant
@YangKeao