Spill in SortAndSpillDiskAction may cause TiDB crash if error happens during sort stage

[windtalker]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

tidb/util/chunk/row_container.go

Lines 631 to 651 in 937feda

	func (a *SortAndSpillDiskAction) Action(t *memory.Tracker) {
	a.m.Lock()
	defer a.m.Unlock()
	// Guarantee that each partition size is at least 10% of the threshold, to avoid opening too many files.
	if a.getStatus() == notSpilled && a.c.GetMemTracker().BytesConsumed() > t.GetBytesLimit()/10 {
	a.once.Do(func() {
	logutil.BgLogger().Info("memory exceeds quota, spill to disk now.",
	zap.Int64("consumed", t.BytesConsumed()), zap.Int64("quota", t.GetBytesLimit()))
	if a.testSyncInputFunc != nil {
	a.testSyncInputFunc()
	c := a.c
	go func() {
	c.sortAndSpillToDisk()
	a.testSyncOutputFunc()
	}()
	return
	}
	go a.c.sortAndSpillToDisk()
	})
	return
	}

In L648, it use go a.c.sortAndSpillToDisk() to start a spill without setting recover function, and in sortAndSpillToDisk()

tidb/util/chunk/row_container.go

Lines 563 to 566 in 937feda

	func (c *SortedRowContainer) sortAndSpillToDisk() {
	c.Sort()
	c.RowContainer.SpillToDisk()
	}

It will first sort the data, then spill it to disk, SpillToDisk() has set recover function, but Sort() does not set recover function, so if error happens during Sort(), TiDB will crash.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)