Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry info for request resource of read requests. #46514

Closed
you06 opened this issue Aug 30, 2023 · 0 comments · Fixed by #46509
Closed

Retry info for request resource of read requests. #46514

you06 opened this issue Aug 30, 2023 · 0 comments · Fixed by #46509
Labels
affects-6.5 affects-7.1 sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.

Comments

@you06
Copy link
Contributor

you06 commented Aug 30, 2023

Enhancement

Currently we can't distinguish the retried requests. Because the read requests may be handled not only by leader, the retry info is important for them. We can attach the retry info to the request soruce for read requests.
@you06 you06 added the type/enhancement The issue or PR belongs to an enhancement. label Aug 30, 2023
@you06 you06 mentioned this issue Aug 30, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 2, 2023
@you06
client-go: attach request source with retry info for coprocessor (#46509
b524a23 
)

close #46514
This was referenced Sep 6, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Sep 7, 2023
@ti-chi-bot
client-go: attach request source with retry info for coprocessor (#46509
cbfa816 
) (#46706)

close #46514
@jebter jebter added the sig/transaction SIG:Transaction label Sep 11, 2023
@cfzjywxk cfzjywxk mentioned this issue Sep 15, 2023
Merged
18 tasks
you06 pushed a commit to you06/tidb that referenced this issue Sep 18, 2023
@ti-chi-bot @you06
client-go: attach request source with retry info for coprocessor (pin…
778b007 
…gcap#46509) (pingcap#46706)

close pingcap#46514
cfzjywxk pushed a commit that referenced this issue Sep 18, 2023
@you06 @ti-chi-bot
client-go: attach request source with retry info for coprocessor (#46706
3bad737 
) (#47003)

* client-go: attach request source with retry info for coprocessor (#46509) (#46706)

close #46514

* restore bazelversiong

Signed-off-by: you06 <[email protected]>

* remove unused field

Signed-off-by: you06 <[email protected]>

* update client-go

Signed-off-by: you06 <[email protected]>

---------

Signed-off-by: you06 <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
@jayl1e jayl1e mentioned this issue Sep 21, 2023
Closed
11 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 16, 2023
@ti-chi-bot
client-go: attach request source with retry info for coprocessor (#46509
359aea8 
) (#46705)

close #46514
guoshouyan pushed a commit to guoshouyan/tidb that referenced this issue Mar 5, 2024
@Tema @you06 @ti-chi-bot
client-go: attach request source with retry info for coprocessor (pin…
92cc413 
…gcap#46706) (pingcap#47003) (pingcap#6)

* client-go: attach request source with retry info for coprocessor (pingcap#46509) (pingcap#46706)

close pingcap#46514

* restore bazelversiong

Signed-off-by: you06 <[email protected]>

* remove unused field

Signed-off-by: you06 <[email protected]>

* update client-go

Signed-off-by: you06 <[email protected]>

---------

Signed-off-by: you06 <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>

Signed-off-by: you06 <[email protected]>
Co-authored-by: you06 <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client-go: attach request source with retry info for coprocessor you06/tidb
3 participants
@jebter @you06 @ti-chi-bot