Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change column hang the ddl #38530

Closed
aytrack opened this issue Oct 18, 2022 · 2 comments · Fixed by #38670
Closed

change column hang the ddl #38530

aytrack opened this issue Oct 18, 2022 · 2 comments · Fixed by #38670
Assignees
Labels
affects-6.4 feature/developing the related feature is in development severity/critical sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@aytrack
Copy link
Contributor

aytrack commented Oct 18, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

drop table if exists t;
create table t (a char(5), b char(10)) partition by list columns (a) (
    partition p0 values in ('0'),
    partition p1 values in ('a'),
    partition p2 values in ('az')
);

alter table t change a a varchar(10);
alter table t change a a int;

2. What did you expect to see? (Required)

change column a from varchar(10) to int success or report unsupport error.

3. What did you see instead (Required)

the session is hang and other ddl can dot execute

-- another session 
TiDB root@127.0.0.1:test> create table t0(a int);
(8027, 'Information schema is out of date: schema failed to update in 1 lease, please make sure TiDB can connect to TiKV')

4. What is your TiDB version? (Required)

TiDB root@127.0.0.1:(none)> select * from information_schema.cluster_info;
+------+-----------------+-----------------+-------------+------------------------------------------+---------------------------+--------------+-----------+
| TYPE | INSTANCE        | STATUS_ADDRESS  | VERSION     | GIT_HASH                                 | START_TIME                | UPTIME       | SERVER_ID |
+------+-----------------+-----------------+-------------+------------------------------------------+---------------------------+--------------+-----------+
| tidb | 127.0.0.1:4000  | 127.0.0.1:10080 | 6.4.0-alpha | 17fac8bc2883dd287481a60f019beae948191a47 | 2022-10-18T19:17:36+08:00 | 4m59.524443s | 3482832   |
| pd   | 127.0.0.1:2379  | 127.0.0.1:2379  | 6.4.0-alpha | bc2019e0c4a0eea1a9559f03a2f9de88511f793e | 2022-10-18T19:17:16+08:00 | 5m19.524447s | 0         |
| tikv | 127.0.0.1:20160 | 127.0.0.1:20180 | 6.4.0-alpha | 26b6c3cfccb386af50b1592ae4583dfb0003d7c1 | 2022-10-18T19:17:20+08:00 | 5m15.52445s  | 0         |
+------+-----------------+-----------------+-------------+------------------------------------------+---------------------------+--------------+-----------+
@aytrack aytrack added type/bug The issue is confirmed as a bug. sig/sql-infra SIG: SQL Infra severity/critical labels Oct 18, 2022
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 labels Oct 18, 2022
@mjonss
Copy link
Contributor

mjonss commented Oct 18, 2022

I don't think this is a critical bug, since the support of change/modify a column on a partitioned table was just added in #38302
So it should not affect any released version.

@aytrack
Copy link
Contributor Author

aytrack commented Oct 19, 2022

Functionally, this issue will cause other DDLs to fail. So I think it is a critical issue. For features under development, we can add the feature/developing tag.

@aytrack aytrack added feature/developing the related feature is in development and removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 labels Oct 19, 2022
@mjonss mjonss self-assigned this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.4 feature/developing the related feature is in development severity/critical sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants