Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable test in the ddl.TestCancel #36582

Closed
hawkingrei opened this issue Jul 26, 2022 · 1 comment · Fixed by #36583 or #53887
Closed

unstable test in the ddl.TestCancel #36582

hawkingrei opened this issue Jul 26, 2022 · 1 comment · Fixed by #36583 or #53887
Labels
component/test severity/minor type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

[2022-07-26T09:15:29.490Z]     testkit.go:310: 
[2022-07-26T09:15:29.490Z]         	Error Trace:	testkit.go:310
[2022-07-26T09:15:29.490Z]         	            				cancel_test.go:327
[2022-07-26T09:15:29.490Z]         	Error:      	An error is expected but got nil.
[2022-07-26T09:15:29.490Z]         	Test:       	TestCancel
[2022-07-26T09:15:29.490Z]         	Messages:   	sql: alter table t_partition add primary key c3_index (c1)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 5, 2024

meet again with a different error, the timeline that might trigger this is

  • we run prepare sql alter table t add index mul_idx2(c1) and it enter synced state, so the MustExec return, but the ddl worker hasn't return
  • we set hook
  • ddl worker call OnJobUpdated, but we don't expect the call here, the check fail
    testutil.go:118: 
        	Error Trace:	pkg/ddl/testutil/testutil.go:118
        	Error:      	not multi-schema change(sql: alter table t drop index mul_idx1, drop index mul_idx2, cancel state: [delete reorganization write only])
        	Test:       	TestCancel
        	Messages:   	use model.SchemaState as the cancel state instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
2 participants