util: Resolve RuntimeStatsColl potential unlock mutex (#55118)

close #55042
pingcap · Aug 1, 2024 · b0aced8 · b0aced8
1 parent da7ed5c
commit b0aced8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/util/execdetails/execdetails.go b/pkg/util/execdetails/execdetails.go
@@ -1301,6 +1301,7 @@ func NewRuntimeStatsColl(reuse *RuntimeStatsColl) *RuntimeStatsColl {
 // RegisterStats register execStat for a executor.
 func (e *RuntimeStatsColl) RegisterStats(planID int, info RuntimeStats) {
 	e.mu.Lock()
+	defer e.mu.Unlock()
 	stats, ok := e.rootStats[planID]
 	if !ok {
 		stats = NewRootRuntimeStats()
@@ -1318,7 +1319,6 @@ func (e *RuntimeStatsColl) RegisterStats(planID int, info RuntimeStats) {
 	if !found {
 		stats.groupRss = append(stats.groupRss, info.Clone())
 	}
-	e.mu.Unlock()
 }
 
 // GetBasicRuntimeStats gets basicRuntimeStats for a executor.