Skip to content

fix: honor -stderrthreshold when -logtostderr=true (#6847) #6869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 2 commits into from
Apr 29, 2026
+16 −3
Merged

fix: honor -stderrthreshold when -logtostderr=true (#6847) #6869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d8f80d
fix: honor -stderrthreshold when -logtostderr=true
pierluigilenoci Apr 22, 2026
fbd4212
fix: handle flag.Set errors to satisfy gosec G104 lint rule
pierluigilenoci Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cmd/tidb-backup-manager/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
package main

import (
"flag"
"fmt"
"os"

"k8s.io/klog/v2"
Expand All @@ -24,6 +26,17 @@ import (

func main() {
klog.InitFlags(nil)
// Opt into the new klog behavior so that -stderrthreshold is honored even
// when -logtostderr=true (the default).
// Ref: kubernetes/klog#212, kubernetes/klog#432
if err := flag.Set("legacy_stderr_threshold_behavior", "false"); err != nil {
fmt.Fprintf(os.Stderr, "failed to set legacy_stderr_threshold_behavior: %v\n", err)
os.Exit(1)
}
if err := flag.Set("stderrthreshold", "INFO"); err != nil {
fmt.Fprintf(os.Stderr, "failed to set stderrthreshold: %v\n", err)
os.Exit(1)
}
if err := app.Run(); err != nil {
os.Exit(1)
}
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ require (
k8s.io/client-go v0.32.13
k8s.io/component-base v0.32.13
k8s.io/gengo/v2 v2.0.0-20250207200755-1244d31929d7
k8s.io/klog/v2 v2.130.1
k8s.io/klog/v2 v2.140.0
k8s.io/kube-openapi v0.0.0-20250318190949-c8a335a9a2ff
k8s.io/kubectl v0.32.13
k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,8 +810,8 @@ k8s.io/component-base v0.32.13 h1:QTroT4xOtYXc8ySp7Wvj5llxDNxz16YoG5Pw3zJBMds=
k8s.io/component-base v0.32.13/go.mod h1:hfuVb9GlAuoIXRimoph+0e862qEwxRA7h+6oOIFelCE=
k8s.io/gengo/v2 v2.0.0-20250207200755-1244d31929d7 h1:2OX19X59HxDprNCVrWi6jb7LW1PoqTlYqEq5H2oetog=
k8s.io/gengo/v2 v2.0.0-20250207200755-1244d31929d7/go.mod h1:EJykeLsmFC60UQbYJezXkEsG2FLrt0GPNkU5iK5GWxU=
k8s.io/klog/v2 v2.130.1 h1:n9Xl7H1Xvksem4KFG4PYbdQCQxqc/tTUyrgXaOhHSzk=
k8s.io/klog/v2 v2.130.1/go.mod h1:3Jpz1GvMt720eyJH1ckRHK1EDfpxISzJ7I9OYgaDtPE=
k8s.io/klog/v2 v2.140.0 h1:Tf+J3AH7xnUzZyVVXhTgGhEKnFqye14aadWv7bzXdzc=
k8s.io/klog/v2 v2.140.0/go.mod h1:o+/RWfJ6PwpnFn7OyAG3QnO47BFsymfEfrz6XyYSSp0=
k8s.io/kube-openapi v0.0.0-20250318190949-c8a335a9a2ff h1:/usPimJzUKKu+m+TE36gUyGcf03XZEP0ZIKgKj35LS4=
k8s.io/kube-openapi v0.0.0-20250318190949-c8a335a9a2ff/go.mod h1:5jIi+8yX4RIb8wk3XwBo5Pq2ccx4FP10ohkbSKCZoK8=
k8s.io/kubectl v0.32.13 h1:SgKMRUwpRIR+8DHPphU/wDskNsj0Jtf6bEVyuus+FtI=
Expand Down
Loading