feat(producer): partition muting for msg ordering#6
Merged
3AceShowHand merged 5 commits intopingcap:v1.41.2-pingcapfrom Apr 15, 2026
Merged
Conversation
wk989898
approved these changes
Apr 15, 2026
When MaxOpenRequests > 1, mute partitions with in-flight batches to prevent out-of-order delivery during retries. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
1b755f5 to
79ef27f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
MaxOpenRequests > 1, mute partitions with in-flight batches to prevent out-of-order delivery during retries.This PR backports the producer ordering fix from IBM/sarama#3422 onto
v1.41.2-pingcap, and keepsgo.modongo 1.25.0.Upstream references and why these changes are needed
IBM/sarama#3422
feat(producer): partition muting for msg ordering8d3ebceafc333a42f6783d43588adbef90a1649afeat(producer): partition muting for msg ordering2a3604789240d5162e739468bd9db362bf60d69ffix(test): retry GetOffset on leader electio29f83cada48f1cba691de9738c14a6399bb3875bfix: simplify muter helpersIBM/sarama#3047 commit
ab8a26611e8a7f08991d06d7d919a88682583221fix(test): refactor helpers into common filesv1.41.2-pingcapdoes not have the shared test helpers that the newer IBM tests rely on (appendInterceptor,closeProducer*,TestMessage). Without backfilling them, the#3422tests do not compile.IBM/sarama#3026 and IBM/sarama#3088
7c75cc4feat(producer): add retry buffer tuning option to prevent OOM26d7c7b51699274209b0b106a3d896377d8cc5f1feat(producer): add MaxBufferBytes to limit retry buffer sizeProducer.Retry.MaxBufferLength/Producer.Retry.MaxBufferBytes, while the newer IBM producer/test code assumes that configuration surface exists.IBM/sarama#3113 commit
4979ecefa0793ca59733b054a8af1038dc6be220chore: bump minimum Go version to 1.23.0go.modisgo 1.25.0, running CI with1.17.x/1.20.x/1.21.xfails immediately on thegodirective/toolchain check. Switching unit/FVT workflows tostable/oldstableand settingGOTOOLCHAIN: localis required to make CI compatible with Go 1.25.IBM/sarama#3160 commit
4d2b166e5c2770f6b23f83eab587d7801878d429fix(ci): bump golangci-lint to v2.golangci.ymlformat is not compatible with the newer golangci-lint releases required for Go 1.25 support.IBM/sarama#3400 commit
265af947chore(deps): update golangci/golangci-lint-action action to v9.2.0IBM/sarama#3482 commit
52f24214chore(deps): update dependency golangci/golangci-lint to v2.11.4IBM/sarama#3453 commit
d4862cechore(deps): bump golang.org/x/net from 0.50.0 to 0.51.0 in the golang-x group across 1 directorymainis already ongo 1.25.0; this PR aligns the pingcap branch CI/tooling with that upstream state instead of downgrading the module directive.Backport-specific notes
go testandgolangci-lintpass under Go 1.25. These are compatibility adjustments for the backport, not new behavior changes.