Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add IF EXISTS and IF NOT EXISTS supported for MariaDB #337

Merged
merged 7 commits into from
Jun 13, 2019
Merged

*: add IF EXISTS and IF NOT EXISTS supported for MariaDB #337

merged 7 commits into from
Jun 13, 2019

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented May 23, 2019 •
edited
Loading

What problem does this PR solve?

for MaraiDB 10.0.2+, ALTER TABLE support IF EXISTS and IF NOT EXISTS clauses for some statements, and CREATE INDEX also support IF NOT EXISTS.

see https://mariadb.com/kb/en/library/alter-table/ and https://mariadb.com/kb/en/library/create-index/

What is changed and how it works?

  1. add IF EXISTS for
    1. DROP COLUMN
    2. CHANGE COLUMN
    3. MODIFY COLUMN
    4. DROP INDEX
    5. DROP FOREIGN KEY
    6. DROP PARTITION
  2. add IF NOT EXISTS for
    1. ADD COLUMN
    2. ADD INDEX
    3. ADD FOREIGN KEY
    4. CREATE INDEX
    5. ADD PARTITION

Check List

Tests

  • Unit test

Corresponding TiDB PR: pingcap/tidb#10723

@CLAassistant
Copy link

CLAassistant commented May 23, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Sign in to view
@codecov

This comment has been minimized.

Sign in to view
kennytm
kennytm reviewed May 29, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label May 29, 2019
@kennytm
Copy link
Contributor

kennytm commented May 29, 2019

@csuzhangxc Is there a corresponding TiDB PR? Otherwise supporting these in the parser level would be misleading.

@csuzhangxc
Copy link
Member Author

@csuzhangxc Is there a corresponding TiDB PR? Otherwise supporting these in the parser level would be misleading.

@kennytm not yet, but I'll open one.

@tiancaiamao
Copy link
Collaborator

LGTM @winkyao

@tiancaiamao tiancaiamao added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels May 31, 2019
@csuzhangxc
Copy link
Member Author

@kennytm @tiancaiamao PTAL again

I also add:

  • IF NOT EXISTS for ADD PARTITION
  • IF EXISTS for DROP PARTITION

kennytm
kennytm previously approved these changes Jun 2, 2019
View reviewed changes
@csuzhangxc csuzhangxc mentioned this pull request Jun 5, 2019
Merged
@winkyao
Copy link
Contributor

winkyao commented Jun 10, 2019

@csuzhangxc Just parse it and ignore it?

winkyao
winkyao previously approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Collaborator

Would you like to update parser.go, please? @csuzhangxc

@csuzhangxc
Merge remote-tracking branch 'remotes/origin/master' into alter_if_ex…
1b79df9 
…ists

# Conflicts:
#	ast/ddl.go
#	parser.go
#	parser.y
#	parser_test.go
@csuzhangxc csuzhangxc dismissed stale reviews from winkyao and kennytm via 1b79df9 June 12, 2019 07:30
@csuzhangxc
Copy link
Member Author

Would you like to update parser.go, please? @csuzhangxc

@tiancaiamao updated and resolved the conflicts.

@tiancaiamao tiancaiamao merged commit d2cf607 into pingcap:master Jun 13, 2019
@csuzhangxc csuzhangxc deleted the alter_if_exists branch June 13, 2019 10:55
@spongedu spongedu mentioned this pull request Aug 10, 2019
Merged
@spongedu spongedu mentioned this pull request Aug 19, 2019
Open
tangenta pushed a commit to tangenta/parser that referenced this pull request Nov 18, 2019
@csuzhangxc @tangenta
*: add IF EXISTS and IF NOT EXISTS supported for MariaDB (pingcap…
42f0c4e 
…#337)
@tangenta tangenta mentioned this pull request Nov 18, 2019
Merged
@ghost ghost mentioned this pull request Aug 29, 2020
Closed
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@csuzhangxc @tiancaiamao
*: add IF EXISTS and IF NOT EXISTS supported for MariaDB (pingcap…
873798c 
…#337)
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@csuzhangxc @tiancaiamao
*: add IF EXISTS and IF NOT EXISTS supported for MariaDB (pingcap…
a72e0a4 
…#337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@winkyao winkyao winkyao left review comments

@kennytm kennytm kennytm left review comments

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csuzhangxc @CLAassistant @kennytm @tiancaiamao @winkyao