-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charset: clean up some code about charset #1306
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
f058035
to
a14e548
Compare
a14e548
to
6edb471
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few exported functions/struct changes:
- Desc/GetCharsetDesc
- GetSupportedCharsets
- GetCharsetInfo
This requires the users to change the code when they upgrade the dependency. I think this is acceptable since the changes should be easy. Please also update the TiDB part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also cleanup collation same way?
/merge |
This pull request has been accepted and is ready to merge. Commit hash: caee1c0
|
I think the whole file should be rewritten. 😅 |
What problem does this PR solve?
Desc
struct, it is definitely same withCharset
Check List
Tests
Code changes