Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: give a more clear recommendation about SELinux #20068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 21, 2025

What is changed, added or deleted? (Required)

Extend the SELinux recommendations:

  • The config is in /etc/selinux/config.
  • On RedHat based systems there is /etc/sysconfig/selinux, which is a symlink to /etc/selinux/config. This symlink is not present on Ubuntu/Debian based systems.
  • On Ubuntu/Debian based systems SELinux tools are not installed by default, so getenforce and the config are not available until extra tools are installed.
  • On Ubuntu/Debian SELinux is not enabled by default, so no action is needed. Note that apparmor is used instead, but this isn't causing issues for TiDB/TiUP.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from bb7133 and qiancai January 21, 2025 06:37
Copy link

ti-chi-bot bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2025
@dveeden dveeden added the area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. label Jan 21, 2025
@dveeden dveeden requested a review from breezewish January 21, 2025 10:55
@qiancai qiancai self-assigned this Jan 26, 2025
@qiancai
Copy link
Collaborator

qiancai commented Jan 26, 2025

/cc @bb7133 @breezewish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants