Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Remove unused field for Cohere chat calls #315

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Mar 6, 2024

Problem

The preamble_override field for cohere chat completion changed to preamble, but we don't actually use it

Solution

Remove the use of preamble

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Existing tests apply

@acatav acatav enabled auto-merge March 6, 2024 13:02
@acatav acatav added this pull request to the merge queue Mar 6, 2024
Merged via the queue into pinecone-io:main with commit 46e4b2c Mar 6, 2024
7 checks passed
@acatav acatav deleted the fix-cohere-field-rename branch March 6, 2024 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants