Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Fix upsert on gcp starter indexes #308

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

izellevy
Copy link
Collaborator

@izellevy izellevy commented Feb 26, 2024

Problem

Gcp starter does not support delete by metadata that fails the upsert.

Solution

Update the is_serverless_env function to catch on gcp-starter.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Improved parameterization in testing.

@izellevy izellevy changed the title Fix/upsert gcp starter Fix upsert on gcp starter indexes Feb 26, 2024
@izellevy izellevy linked an issue Feb 26, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@miararoy miararoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@izellevy izellevy added this pull request to the merge queue Feb 26, 2024
Merged via the queue into pinecone-io:main with commit 050869d Feb 26, 2024
7 checks passed
@izellevy izellevy deleted the fix/upsert_gcp_starter branch February 26, 2024 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Upsert in Starter is Failing due to deletion
2 participants