This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Add deployment guide (GCP) #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igiloh-pinecone
suggested changes
Jan 3, 2024
|
|
||
| ```bash | ||
| # Pull the Canopy Docker image | ||
| docker pull ghcr.io/pinecone-io/canopy:{canopy-version} |
There was a problem hiding this comment.
This should probably be :latest, and you can mention that we also have individual version images
There was a problem hiding this comment.
I think latest is not a good practice in general for deployments. (It is handy to check the functionality though.) More context here: https://vsupalov.com/docker-latest-tag/#:~:text=You%20should%20avoid%20using%20the,apart%20from%20the%20image%20ID.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't have a guide for Cloud deployments.
Solution
Added a guide for GCP.
Type of Change
Test Plan
Describe specific steps for validating this change.