This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Cleanup indexes in case of failure #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igiloh-pinecone
approved these changes
Dec 20, 2023
.github/workflows/PR.yml
Outdated
| echo "Test Run ID: ${run_id}" | ||
| echo "run_id=${run_id}" >> $GITHUB_OUTPUT | ||
| - name: Cleanup indexes | ||
| if: failure() && github.event_name == 'merge_group' |
There was a problem hiding this comment.
Suggested change
| if: failure() && github.event_name == 'merge_group' | |
| if: always() && github.event_name == 'merge_group' |
Let's not take any chances. The added time for successful tests is probably negligible.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
igiloh-pinecone
approved these changes
Dec 20, 2023
| logger.info("Usage: python scripts/cleanup_indexes.py <testrun_uid>") | ||
| sys.exit(1) | ||
|
|
||
| testrun_uid = sys.argv[1] |
There was a problem hiding this comment.
Please promise me that if we're every adding even more one parameter, we're switching to argparse 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When an action get cancelled pytest is stopped using SIGKILL (by Github CI) which causes unused indexes to remain after the test.
Solution
Add a new step to clean up the indexes in case the run is interrupted in the middle.
Type of Change
Test Plan
Describe specific steps for validating this change.