Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Update README.md #192

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Update README.md #192

merged 1 commit into from
Nov 30, 2023

Conversation

tomer-w
Copy link
Contributor

@tomer-w tomer-w commented Nov 29, 2023

Fix the syntax of the bash export section.

Problem

Missing " in the export INDEX_NAME line

Solution

Added it.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • [x ] Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

tested the export line.

Fix the syntax of the bash export section.
@@ -64,7 +64,7 @@ pip install canopy-sdk
export PINECONE_API_KEY="<PINECONE_API_KEY>"
export PINECONE_ENVIRONMENT="<PINECONE_ENVIRONMENT>"
export OPENAI_API_KEY="<OPENAI_API_KEY>"
export INDEX_NAME=<INDEX_NAME>
export INDEX_NAME="<INDEX_NAME>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it would work both with and without "...

But sure, let's merge this

Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomer-w tomer-w added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit 46c39b6 Nov 30, 2023
10 checks passed
@tomer-w tomer-w deleted the tomer-w-patch-1 branch November 30, 2023 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants