This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
CLI: read config file from env location (Issue #189) #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the way the config file is loaded by the Canopy CLI. When the config file location is not specified through the `-c` parameter, we use the file location specified in the environment variable CANOPY_COPY_FILE.
src/canopy_cli/cli.py
Outdated
| @@ -102,7 +102,9 @@ def _initialize_tokenizer(): | |||
|
|
|||
| def _read_config_file(config_file: Optional[str]) -> Dict[str, Any]: | |||
| if config_file is None: | |||
| return {} | |||
| config_file = os.getenv("CANOPY_CONFIG_FILE", None) | |||
There was a problem hiding this comment.
I believe click has a built-in solution.
If you'll look at the click declaration of the --index-name argument of canopy new, you'd notice an envvar= option that that automatically sets that argument to also be read from an en var.
igiloh-pinecone
approved these changes
Dec 10, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug described in issue #189.
Problem
The issue occurs then the user runs a Canopy CLI command (such as
new,upsert) and does not specify the-cparameter with a config file lcoation.The current behaviour is to default to an empty (default) configuration while the user might expect Canopy to read the config file location specified in the environment variable
CANOPY_CONFIG_FILE.Solution
This change updates the way the config file is loaded by the Canopy CLI. When the config file location is not specified through the
-cparameter, we use the file location specified in the environment variable CANOPY_COPY_FILE.Type of Change
Test Plan
Only manual testing was done for this change.