This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 121
Improve dataloader error handling #182
Merged
miararoy
merged 11 commits into
pinecone-io:main
from
miararoy:improve-dataloader-error-hadnling
Dec 12, 2023
Merged
Improve dataloader error handling #182
miararoy
merged 11 commits into
pinecone-io:main
from
miararoy:improve-dataloader-error-hadnling
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igiloh-pinecone
suggested changes
Dec 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miararoy see a few suggestions please
Co-authored-by: igiloh-pinecone <[email protected]>
izellevy
changed the title
Improve dataloader error hadnling
Improve dataloader error handling
Dec 11, 2023
igiloh-pinecone
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
data loading has no meaningful error handling, albeit being a sensitive part of the flow
resolves: #181
Solution
first, defining
DataLoaderException
that will formalize all data loading error on both the file/row level and unify them under one error, then change the exception handling to raise this errorType of Change
Test Plan
note that tests should were added to txt -> df as from df to documents is handled.