This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
add version to app.py routes #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igiloh-pinecone
suggested changes
Nov 13, 2023
src/canopy_cli/cli.py
Outdated
Comment on lines
532
to
533
| @click.option("--host", default="localhost", | ||
| help="Hostname or address to bind the server to. Defaults to localhost") |
There was a problem hiding this comment.
This particular change wasn't tested on all OSes (passing host='localhost' to uvicorn.run()).
If you wanna merge it, we will need to test it.
There was a problem hiding this comment.
does 0.0.0.0 works?
There was a problem hiding this comment.
on all OSs - that is
There was a problem hiding this comment.
If that was the code in main before this PR - then yeah. I tested this code on all 3 OSes manually yesterday.
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| from canopy.models.data_models import Messages, Query, Document | |||
|
|
|||
| # TODO: consider separating these into modules: Chat, Context, Application, etc. | |||
igiloh-pinecone
approved these changes
Nov 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Versioning an API is a crucial aspect of maintaining its usability and compatibility as it evolves over time. There are several approaches to API versioning but the most common is URI Versioning (Path Versioning): where the version number is included in the URL path. For example:
Solution
Type of Change
Test Plan
Regression