Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider BIC in Stripe 2.0 #578

Closed
paltman opened this issue Jul 18, 2018 · 4 comments · Fixed by #581
Closed

Consider BIC in Stripe 2.0 #578

paltman opened this issue Jul 18, 2018 · 4 comments · Fixed by #581

Comments

@paltman
Copy link
Contributor

paltman commented Jul 18, 2018

Issue Summary

A new version of the python library for Stripe was released and includes some backwards incompatible changes.

We should test and address them:

https://github.com/stripe/stripe-python/blob/master/CHANGELOG.md#200---2018-07-10

@blueyed
Copy link
Contributor

blueyed commented Jul 30, 2018

#574
(1 week older than this issue already)

@blueyed
Copy link
Contributor

blueyed commented Jul 30, 2018

For now I think stripe-python should be pinned at least.

@paltman
Copy link
Contributor Author

paltman commented Aug 4, 2018

@blueyed Sorry that I missed your PR. I've been away from Pinax for a bit due to work commitments. Looking to catch back up shortly but these seem priority. My plan is to do the following:

  1. Release a new minor version of pinax-stripe (v4.4.0) pinned to stripe-python<2,>=1.7.9
  2. Merge Support stripe-python 2.0 #574
  3. Release a new minor version (since the change should be BC with integrations, I don't think it warrants a major version bump) of pinax-stripe (v4.5.0) pinned to stripe-python>=2

@paltman
Copy link
Contributor Author

paltman commented Aug 4, 2018

I suspect the dependency caching in CI has prevented errors from triggering

botondus added a commit to botondus/django-stripe-payments that referenced this issue Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants