Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move templates to pinax-templates #15

Open
grahamu opened this issue Jan 15, 2018 · 2 comments
Open

move templates to pinax-templates #15

grahamu opened this issue Jan 15, 2018 · 2 comments

Comments

@grahamu
Copy link
Contributor

grahamu commented Jan 15, 2018

Move change_list.html and one_off_list.html templates into into pinax-templates, with similar semantic markup as other templates in that app.
@jaydenwindle
Copy link

jaydenwindle commented Jan 15, 2018 •
edited
Loading

It seems like these templates are extending from admin templates. I don't see a similar usage of admin templates in any of the other pinax projects. Were other projects previously dependent on admin templates and then changed? Do you have any preferences as to how they are included?

@grahamu
Copy link
Contributor Author

grahamu commented Jan 15, 2018

@jaydenwindle seems reasonable to create an admin dir under pinax in pinax-templates, and extend from there just like is seen in pinax-points.

This was referenced Jan 15, 2018
Open
Open
@KatherineMichel KatherineMichel mentioned this issue Jul 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grahamu @jaydenwindle