Move over pinax-points templates #2
Conversation
| @@ -0,0 +1,18 @@ | |||
| {% extends "admin/change_list.html" %} | |||
There was a problem hiding this comment.
I think this is at the wrong path.
Since this is an admin override I think you want it at the path:
pinax/templates/templates/admin/pinax/points/awardedpointvalue/change_list.html
but not entirely sure. It might be:
pinax/templates/templates/admin/pinax_points/awardedpointvalue/change_list.html
Because of the app lable: https://github.com/pinax/pinax-points/blob/master/pinax/points/apps.py#L8
There was a problem hiding this comment.
Good catch - those long paths got me 😆
There was a problem hiding this comment.
This admin file looks out of place to not be in the points directory. Are you sure it should be in its own separate admin folder in pinax-templates? If pinax-points were included in a starter project, perhaps the admin templates would be in the project templates folder. https://github.com/jaydenwindle/pinax-templates/tree/move_pinax_points_templates/pinax/templates/templates/pinax
|
|
||
| {% load i18n admin_modify adminmedia %} | ||
|
|
||
| {% block extrastyle %}{{ block.super }}<link rel="stylesheet" type="text/css" href="{% admin_media_prefix %}css/forms.css" />{% endblock %} |
There was a problem hiding this comment.
We don't want to ship static as part of the apps either. This should be moved into starter project sass.
There was a problem hiding this comment.
nevermind, this is part of the admin system. hm...
There was a problem hiding this comment.
Yeah, these templates are pretty tightly tied to the admin system. Feels a bit odd to put them side by side with the rest of the pinax templates given the differences. If there's a better way to do this I'd love to hear!
|
|
||
| <div class="submit-row"> | ||
| {% trans "Award" as submit_text %} | ||
| <input type="submit" value="{{ submit_text }}" class="default" /> |
There was a problem hiding this comment.
I prefer the use of <button> now but not sure this should hold things up.
|
Where are we at with this PR? Are there still changes to be made? |
|
Man, it's been ages since I worked on this. From what I recall, moving these templates over was mentioned in Slack as a blocker for getting Looks like the v1.0 release is out now, so I'm not sure if this PR and pinax/pinax-points#16 are still relevant. If not, feel free to close :) |
|
@jaydenwindle Sorry for the length of time. I'm going through PRs and issues and making sense of ones that have been here for a while. I think it is still relevant, just not sure if anything needs to change with it. I'd love to get it closed bc/it involves 2 issues and a PR! |
Moves the templates from pinax-points to this project to prepare for pinax-points v1.0.0 release.
These templates are a little different than templates from most other pinax apps as they are admin-specific, and seem to be tightly coupled with the
one_off_pointsadmin functionality from pinax-points.Fixes pinax/pinax-points#15.