Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready version 3.3 #372

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Ready version 3.3 #372

merged 2 commits into from
Sep 7, 2023

Conversation

blag
Copy link
Collaborator

@blag blag commented Sep 7, 2023

Changes proposed in this PR:

  • Exclude more files from our built distribution (eg: tests/, tox.ini, docs/Makefile, docs/conf.py)
  • Simplify pyproject.toml a bit regarding what files to include
  • Bump version to 3.3.0 for release

I verified that the built distribution only contains the appropriate files

Click here to see distribution file list
❯ tree dist/django-user-accounts-3.3.0
dist/django-user-accounts-3.3.0
├── CHANGELOG.md
├── LICENSE
├── MANIFEST.in
├── PKG-INFO
├── README.md
├── account
│   ├── __init__.py
│   ├── admin.py
│   ├── auth_backends.py
│   ├── conf.py
│   ├── context_processors.py
│   ├── decorators.py
│   ├── fields.py
│   ├── forms.py
│   ├── hooks.py
│   ├── languages.py
│   ├── locale
│   │   ├── ar
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── de
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── es
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── fa_IR
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── fr
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── it
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── ja
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── nl
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── pl
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── pt_BR
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── ru
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── sk_SK
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── tr
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   ├── zh_CN
│   │   │   └── LC_MESSAGES
│   │   │       ├── django.mo
│   │   │       └── django.po
│   │   └── zh_TW
│   │       └── LC_MESSAGES
│   │           ├── django.mo
│   │           └── django.po
│   ├── managers.py
│   ├── middleware.py
│   ├── mixins.py
│   ├── models.py
│   ├── signals.py
│   ├── timezones.py
│   ├── urls.py
│   ├── utils.py
│   └── views.py
├── django_user_accounts.egg-info
│   ├── PKG-INFO
│   ├── SOURCES.txt
│   ├── dependency_links.txt
│   ├── requires.txt
│   └── top_level.txt
├── docs
│   ├── commands.rst
│   ├── faq.rst
│   ├── index.rst
│   ├── installation.rst
│   ├── migration.rst
│   ├── settings.rst
│   ├── signals.rst
│   ├── templates.rst
│   └── usage.rst
├── pyproject.toml
└── setup.cfg

35 directories, 70 files

Tips for an ideal PR

@blag blag force-pushed the ready-version-3.3 branch from 0e38872 to 28d9277 Compare September 7, 2023 08:19
Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@uhurusurfa uhurusurfa merged commit 2fab0e7 into pinax:master Sep 7, 2023
@blag blag deleted the ready-version-3.3 branch September 7, 2023 22:02
@blag
Copy link
Collaborator Author

blag commented Sep 7, 2023

Sweet, thanks for the merge. I'll see if I can publish this new version to PyPI.

@VichoReyes
Copy link

VichoReyes commented Sep 8, 2023

Aren't migration files missing?

EDIT: Sorry for the terseness. I have a project that indirectly depends on pinax-invitations, which depends on this package. We don't use a requirements.txt with versions, so when our CI started failing recently, the likely culprit was a dependency update. The error was this one (when running makemigrations):

django.db.migrations.exceptions.NodeNotFoundError: Migration pinax_invitations.0001_initial dependencies reference nonexistent parent node ('account', '0001_initial')

With django-user-accounts 3.2, directory site-packages/account/migrations existed, and now with 3.3 it doesn't.

@blag
Copy link
Collaborator Author

blag commented Sep 8, 2023

Thank you for catching this. Yes, it's now missing migrations.

If I had a nickel for every time I messed up setuptools packaging config, I'd be unfathomably rich.

Fix and version bump PR incoming. Also looking into yanking the broken package from PyPI.

@blag
Copy link
Collaborator Author

blag commented Sep 8, 2023

I don't have permission to yank the package from PyPI.

Fix PR is #373.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants