Fixes issue #287 #298
Closed
Fixes issue #287 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… subsequent changes which refer to the said model
|
I have never come across this being a problem in all the time I've used DUA and the predecessor django-email-confirmation with this field name (and it's been the same for the entirety of Pinax). Is there some tool being used that didn't properly escape field names? I am not against this change, but I really would rather understand what is causing the problem before committing to a change like this. |
|
closing as I agree with @brosner and it's been a few years with no response to his question. happy to reconsider if there is support for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'primary' is an sql reserved keyword and hence, and a field name is named that. This pull request changes all references of the field 'primary' to 'is_primary', it has changed all references in all functions which use 'primary' for whatever purpose and has also run migrations (as the field name has been changed).