hub75: don't enable an unrelated IRQ #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DREQs are not IRQs, `DREQ_PIO0_TXn` happens to align with `TIMER_IRQ_n` so this enabled a timer IRQ.
|
More importantly, just noticed that stop would disable that IRQ which seems a lot more likely to break things... |
|
😬 I feel this pattern might be copied into a few places, will have a hunt. Thank you! Well quick look here and apparently it isn't, whew! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DREQs are not IRQs,
DREQ_PIO0_TXnhappens to align withTIMER_IRQ_nso this enabled a timer IRQ.(This is something I happened to notice while poking around in there)