Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove common Micro.blog elements from head and use new partial instead #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

svendahlstrand
Copy link
Contributor

Hey! 👋 This pull request introduces the new partial that is provided by the Micro.blog environment. With that, we know that all the necessary Micro.blog head elements are present, with the added bonus of making this theme compatible with Hugo 0.117.

I'm not bumping the version number; that's up to you, @pimoore, should you decide to merge this one.

@pimoore
Copy link
Owner

pimoore commented Oct 23, 2023

@svendahlstrand I'm a little out of my element with this one. Is there anything I need to change outside of adding this partial, such as modifying/deleting any other files?

@svendahlstrand
Copy link
Contributor Author

Well, I can't tell you with 100% certainty. In theory, you could have JavaScript or some other external thing that depends on how stuff was organized in the head before this change. But I think that's highly unlikely. And I have tested the theme on my machine with the changes introduced in this pull request, and it worked okay.

But, as with any change, it's probably a good idea for you to test my changes as well before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants