Skip to content

provide more detailed error info and align messages stylistically #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 6, 2024
Merged

provide more detailed error info and align messages stylistically #63

merged 5 commits into from
Dec 6, 2024

Conversation

@niklasf
Copy link
Collaborator

@niklasf niklasf commented Dec 3, 2024

Found these improvements to error handling helpful in debugging/monitoring:

  • Capture io::Error
  • Provide more detailed error info, even if response does not match https://mozilla-services.github.io/autopush-rs/errors.html (fallback to errno 999 - Unknown error with response body)
  • Align error messages stylistically
  • Remove unused WebPushError::{SslError, TlsError} (since this PR contains semver-breaking changes anyway)

@niklasf
Copy link
Collaborator Author

niklasf commented Dec 3, 2024

Also fixed unrelated warning to pass CI on latest stable.

@andyblarblar
Copy link
Collaborator

andyblarblar commented Dec 6, 2024

Oooo nice work, those error types were annoying me for some time. I think that CI fix should unblock that other PR as well, good all around.

@andyblarblar andyblarblar merged commit 3f55333 into pimeys:master Dec 6, 2024
11 checks passed
@naskya naskya mentioned this pull request Feb 20, 2025
Closed
niklasf added a commit that referenced this pull request Feb 22, 2025
@niklasf
Revert "provide more detailed error info and align messages stylistic…
35eced9 
…ally (#63)"

This reverts commit 3f55333.

Undo the semver break for a final 0.10.x release (#71).
niklasf added a commit that referenced this pull request Feb 22, 2025
@niklasf
Revert "provide more detailed error info and align messages stylistic…
1669c63 
…ally (#63)"

This reverts commit 3f55333.

Undo the semver break for a final 0.10.x release (#71).
niklasf added a commit to niklasf/rust-web-push that referenced this pull request Feb 22, 2025
@niklasf
Reapply "provide more detailed error info and align messages stylisti…
1d06df4 
…cally (pimeys#63)"

This reverts commit 1669c63.
niklasf added a commit that referenced this pull request Feb 22, 2025
@niklasf
Reapply "provide more detailed error info and align messages stylisti…
47cae33 
…cally (#63)"

This reverts commit 1669c63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@niklasf @andyblarblar