[Bug]: Fix unique constraint issue when updating advanced many-to-many #17344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
kingjia90
commented
Jul 15, 2024
|
|
but wait, i cannot reproduce the error described in pimcore/data-hub#819 anymore, @dkarlovi would you be able to check if it is still throwing errors? |
|
@kingjia90 Just tried to reproduce the issue described in the data-hub. Stumbled upon it while working on other things and was interested. Couldn´t reproduce it as well, updating the quantity in the relation's metadata worked fine. @dkarlovi Is the problem still there for you? Could you please try to reproduce it once again? Would be appreciated. |
…onstraint # Conflicts: # bundles/CoreBundle/src/DependencyInjection/Compiler/FlysystemVisibilityPass.php # bundles/CustomReportsBundle/src/Controller/Reports/CustomReportController.php # bundles/InstallBundle/src/Installer.php # lib/Tool.php # models/DataObject/ClassDefinition/Data/ReverseObjectRelation.php
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Potentially resolves #16265
Additional info
It seems that #15746 applied only to
ObjectMetadata's CREATE TABLE while the migration ran for bothObjectMetadataandElementMetadata(as it should, supposing the ObjectMetadata anti-deadlock changes are fine).So existing data at the time migration ran are fine, anything new afterwards is likely not working fine and won't work with the fixes because
metadata_undoesn't exists.A little bit tricky because we basically need to re-run
Pimcore\Bundle\CoreBundle\Migrations\Version20230616085142somehow but shouldn't be in a bugfix release.