Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: User::getById('admin') returns "system" user #15086

Merged
merged 2 commits into from
May 15, 2023
Merged

Fix: User::getById('admin') returns "system" user #15086

merged 2 commits into from
May 15, 2023

Conversation

blankse
Copy link
Contributor

@blankse blankse commented May 3, 2023

Fix #15051

Same is in AbstractObject

pimcore/models/DataObject/AbstractObject.php

Lines 369 to 371 in a5b86f3

if (!is_numeric($id) || $id < 1) {
return null;
}

@github-actions
Copy link

github-actions bot commented May 3, 2023

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Bug fix: check if files are affected that were moved to a bundle - create a PR there if applicable
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@blankse blankse mentioned this pull request May 3, 2023
Closed
@mattamon mattamon added the Bug label May 3, 2023
@dvesh3 dvesh3 added this to the 10.5.23 milestone May 15, 2023
martineiber
martineiber approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blankse

@martineiber martineiber merged commit f223541 into pimcore:10.5 May 15, 2023
@blankse blankse deleted the patch-2 branch May 15, 2023 11:16
blankse added a commit to blankse/pimcore that referenced this pull request May 16, 2023
@blankse
Followup to pimcore#15086
a6886d4
kingjia90 pushed a commit that referenced this pull request Aug 1, 2023
@blankse
[PhpStan] checkAlwaysTrueCheckTypeFunctionCall: true (#14799)
130fd27 
* [PhpStan] checkAlwaysTrueCheckTypeFunctionCall: true
* Followup to #15086
* Update phpstan version and update baseline
* Update composer.json
* Change count checks for arrays
* Throw exception if getPdf couldn't load the resource
solverat pushed a commit to solverat/pimcore that referenced this pull request Aug 5, 2023
@blankse @solverat
[PhpStan] checkAlwaysTrueCheckTypeFunctionCall: true (pimcore#14799)
a42731d 
* [PhpStan] checkAlwaysTrueCheckTypeFunctionCall: true
* Followup to pimcore#15086
* Update phpstan version and update baseline
* Update composer.json
* Change count checks for arrays
* Throw exception if getPdf couldn't load the resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martineiber martineiber martineiber approved these changes

Assignees

@martineiber martineiber

Labels
Bug
Projects
None yet
Milestone
10.5.23
Development

Successfully merging this pull request may close these issues.
4 participants
@blankse @martineiber @dvesh3 @mattamon