Decouple AdminBundle from the Core #14918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
dvesh3
changed the title
dvesh3
commented
Apr 13, 2023
There was a problem hiding this comment.
We have another blocker on Pimcore 11: \Pimcore\Bundle\AdminBundle\System\Config is used in the core to get the config based on LocationAwareConfigRepository. If these can't be refactored then changes in this PR are not relevant.
Also need to consider:
- Bundles relying on
adminjsoncalls in AdminController which usesAdminSerializer. (they can't simply switch fromAdminControllertoUserAwareController). - BundleManagerEvents used in PimcoreBundleManager
- IndexActionSettingsEvent
- Tool::getLanguageFile using
AdminBundle\Tool::getLanguageFile - Core tests relying on admin bundle
- Admin events triggered from the core e.g.
pimcore/models/Element/AbstractElement.php
Line 507 in 5344968
|
can't that config be moved to the core? |
@dpfaffenbauer yes, we are working on separating the configs belongs to the core and admin bundle so the correct config can be read from their respective config service. There will be a follow up to #14867 |
brusch
requested changes
Apr 14, 2023
…r and add isolated serializer for Core
dvesh3
commented
Apr 14, 2023
mattamon
reviewed
Apr 17, 2023
brusch
previously requested changes
Apr 17, 2023
bundles/AdminBundle/EventListener/AdminAuthenticationDoubleCheckListener.php
Show resolved
Hide resolved
dvesh3
added a commit
that referenced
this pull request
Apr 19, 2023
dvesh3
added a commit
to pimcore/admin-ui-classic-bundle
that referenced
this pull request
Apr 19, 2023
Merged
dvesh3
added a commit
that referenced
this pull request
Apr 21, 2023
dvesh3
added a commit
that referenced
this pull request
Apr 24, 2023
aryaantony92
pushed a commit
that referenced
this pull request
Apr 24, 2023
mattamon
added a commit
that referenced
this pull request
Apr 24, 2023
* [Pimcore 11] Decouple AdminBundle from the Core - follow up to #14918 * Fix Core Bundles & Security classes * require dev branch (temproray) of admin ui classic bundle * Make Core bundles implement PimcoreBundleAdminClassicInterface * Further decoupling * Fix tests * Further decoupling * Further decoupling * check disabling admin bundle * Fix stan issues * Move Admin Listeners to admin-classic.yaml * Add ignore again and void to method * Extend phpstand-baseline.neon and phpstan-parameters.neon * Revert unrelated changes * Refactor initializing system settings for tests * Adding void return type * Remove line from baseline.neon * Add interface * Extract AdminBundle tests from core. * extract testAddGridFeatureJoinsWithTwoFilters into AdminBundle. * Fix tests * Fix tests * Fix phpstan baseline - remove ignored errors * cleanup phpstan baseline * review changes * fix phpstan baseline * Fix docs related to bundle support interface & trait --------- Co-authored-by: mattamon <[email protected]> Co-authored-by: Martin Eiber <[email protected]>
mattamon
pushed a commit
to pimcore/admin-ui-classic-bundle
that referenced
this pull request
Apr 24, 2023
* Decouple from the core - changes related to pimcore/pimcore#14918 & pimcore/pimcore#14971 * Adapt more controllers to use new abstract * fix typo * Further decoupling * Fix Stan * Use ElementService::getCustomViewById * review changes * review changes * Remove unrelated * Remove unused classes
dvesh3
added a commit
that referenced
this pull request
May 9, 2023
* Decouple AdminBundle from the Core - related to #12531 * Re-add AdminController * Re-add services with deprecations * Use Pimcore JsonResponse * Fix typo * Move back EditmodeListener, Move deprecated methods to AdminController and add isolated serializer for Core * naming optimizations * TokenUsageResolver: Return correct user proxy from deprecated class * resgister new UserProvider service * fix tests * review changes * required injections * Review changes & move password hasher to the core * Replace deprecated usages of AdminController * Fix Stan * Revert Serializer DI * Fix bundle manager DI * Fix tests * Ecommerce controllers extends UserAwareController * Fix Stan * Fix Stan
dvesh3
added a commit
that referenced
this pull request
May 9, 2023
dvesh3
added a commit
that referenced
this pull request
May 9, 2023
dvesh3
added a commit
that referenced
this pull request
May 16, 2023
dvesh3
added a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Related to #12531