-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move personalization to own bundle #14102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
…aobject configuration of target group to bundle
…er in DocumentRenderer.php
…ction from standard document page in the core
…om/pimcore/pimcore into move_personalization_to_own_bundle
# Conflicts: # bundles/AdminBundle/public/js/pimcore/document/document.js # bundles/AdminBundle/public/js/pimcore/document/page_snippet.js # composer.json # doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
…le' into move_personalization_to_own_bundle
dvesh3
added a commit
that referenced
this pull request
Feb 17, 2023
dvesh3
added a commit
that referenced
this pull request
Feb 17, 2023
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #12523
Additional info
To do
Usage of DocumentTargetingConfigurator (bundle specific) in classes like
pimcore/lib/Templating/Renderer/IncludeRenderer.php
Line 85 in 68e8678
pimcore/models/Document/Editable/Renderlet.php
Line 137 in 68e8678
pimcore/models/Document/Editable/Snippet.php
Line 107 in 68e8678
DebugStopwatchPass.php uses the services which are specific to the bundle. Move them to the bundle
Usage of the datatype TargetGroup in DefaultAdapter.php
https://github.com/pimcore/pimcore/blob/11.x/lib/Document/Newsletter/AddressSourceAdapter/DefaultAdapter.php
models\Document\Editable\Snippet.php calls the method in the newly introduced bundle specific trait "TargetDocumentTrait"
pimcore/models/Document/Editable/Snippet.php
Line 125 in 68e8678