[DataObject\Document] getChildren & getSiblings shouldn't load the listing #13899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
|
@dvesh3 Why is only the getChildren() method changed of the Document Model and not the getSiblings() method? |
|
And why isn't changed the Asset model to be consistent? |
blankse
reviewed
Jan 9, 2023
| @@ -597,7 +594,7 @@ public function getChildren(bool $includingUnpublished = false): array | |||
| $list->setCondition('parentId = ?', $this->getId()); | |||
| $list->setOrderKey('index'); | |||
| $list->setOrder('asc'); | |||
| $this->children[$cacheKey] = $list->load(); | |||
| $this->children[$cacheKey] = $list; | |||
| } else { | |||
| $this->children[$cacheKey] = []; | |||
There was a problem hiding this comment.
@dvesh3 The return type doesn't allow an array. Should be also a listing. Or should we return null if no Listing is possible?
blankse
reviewed
Jan 9, 2023
Comment on lines
+674
to
+676
| $listing = $target->getChildren(); | ||
| $listing->setData(array_merge($listing->getData(), [$newElement])); | ||
| $target->setChildren($listing); |
There was a problem hiding this comment.
This is also used for Assets. So we must change it also there.
|
@blankse thanks for the review. yes, we missed few points here so i'll create a follow up PR. thanks! |
dvesh3
added a commit
that referenced
this pull request
Jan 9, 2023
dvesh3
added a commit
that referenced
this pull request
Jan 9, 2023
dvesh3
added a commit
that referenced
this pull request
Jan 9, 2023
dvesh3
added a commit
that referenced
this pull request
Jan 9, 2023
dvesh3
added a commit
that referenced
this pull request
Jan 9, 2023
dvesh3
added a commit
that referenced
this pull request
Jan 10, 2023
dvesh3
added a commit
that referenced
this pull request
Jan 10, 2023
dvesh3
added a commit
that referenced
this pull request
Jan 10, 2023
dvesh3
added a commit
that referenced
this pull request
Jan 17, 2023
robertSt7
pushed a commit
that referenced
this pull request
Jan 23, 2023
…low up to #13899 (#14008) * [Elements] getChildren & getSiblings shouldn't load the listing - follow up to #13899 * [Elements] getChildren & getSiblings shouldn't load the listing - follow up to #13899 * [Elements] getChildren & getSiblings shouldn't load the listing - follow up to #13899 * [Elements] getChildren & getSiblings shouldn't load the listing - follow up to #13899 * Update models/Asset.php Co-authored-by: Sebastian Blank <[email protected]> * [Elements] getChildren & getSiblings shouldn't load the listing - follow up to #13899 * [Elements] getChildren & getSiblings shouldn't load the listing - follow up to #13899 * [Elements] getChildren & getSiblings shouldn't load the listing - follow up to #13899 * [Elements] getChildren & getSiblings shouldn't load the listing - follow up to #13899 * [Elements] getChildren & getSiblings shouldn't load the listing - follow up to #13899 Co-authored-by: Sebastian Blank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #11737
Additional info