Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix: Show in Treeview not working #783

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

marvin-bilharz
Copy link
Contributor

@marvin-bilharz marvin-bilharz commented Dec 5, 2024

Resolves #778

since globalState.pathIds is an array of strings, to compare it, rootNodeId has to be string too. Otherwise index wont be found.

Tested in:
Chrome 131.0.6778.108
Pimcore 11.4.3

Copy link

github-actions bot commented Dec 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@marvin-bilharz marvin-bilharz changed the title Fix: Show in Treeview not working [Bug] Fix: Show in Treeview not working Dec 5, 2024
@marvin-bilharz
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@marvin-bilharz
Copy link
Contributor Author

recheck

@blankse
Copy link
Contributor

blankse commented Dec 5, 2024

@marvin-bilharz Duplicate of #779

@nathaliemohrsynaigy
Copy link

I just stumbled upon the show in tree not working anymore and found this PullRequest :).
The fix works in my local env, looking forward for it being released.

@robertSt7 robertSt7 changed the base branch from 1.x to 1.7 December 10, 2024 09:42
@robertSt7

This comment was marked as resolved.

since globalState.pathIds is an array of strings, to compare it, rootNodeId has to be string too. Otherwise index wont be found. Tested in Chrome 131.0.6778.108
@kingjia90 kingjia90 changed the base branch from 1.7 to 1.6 December 10, 2024 16:06
@kingjia90 kingjia90 merged commit 03484c0 into pimcore:1.6 Dec 10, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
@kingjia90 kingjia90 modified the milestones: 1.6.4, 1.6.5 Dec 11, 2024
@fashxp fashxp linked an issue Dec 17, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Show in tree is not working
6 participants