Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Readding check to solve update/move problem of objects #757

Merged
merged 3 commits into from
Nov 21, 2024
Merged

[Bug] Readding check to solve update/move problem of objects #757

merged 3 commits into from
Nov 21, 2024

Conversation

mattamon
Copy link
Contributor

Resolves #756

@mattamon mattamon added the Bug label Nov 19, 2024
@mattamon mattamon added this to the 1.6.3 milestone Nov 19, 2024
@mattamon mattamon requested a review from kingjia90 November 19, 2024 15:51
kingjia90
kingjia90 reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@kingjia90 kingjia90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just suggesting to add a comment to explain why it has to be there even though it looks like repetead code

@mattamon @kingjia90
Add explanation comment
df8aec5 
Co-authored-by: JiaJia Ji <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@robertSt7 robertSt7 self-assigned this Nov 21, 2024
@robertSt7 robertSt7 merged commit 389d02f into 1.6 Nov 21, 2024
10 checks passed
@robertSt7 robertSt7 deleted the fix-long-loading-times branch November 21, 2024 12:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingjia90 kingjia90 kingjia90 left review comments

Assignees

@robertSt7 robertSt7

Labels
Bug Pimcore:ToDo
Projects
None yet
Milestone
1.6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mattamon @kingjia90 @robertSt7 @wisconaut