Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Custom asset metadata of type object cant be set in asset gridview. #706

Merged

Conversation

bk-hitcom
Copy link
Contributor

Custom asset metadata of type object cant be set in asset gridview. State were never set.

Steps to reproduce:

Creating a custom asset meta data of type object and assign it to an image
Switch to grid view of the asset directory
Selecting the created custom metadata of type object for display in the grid
Click on the field and link a data object
In the CellEditor click on save
=> The relation is not adopted

The change is not recognized as a change in the manyToOneRelation class because the variable "this.dataChanged" never changes to "true".

Error was introduced by a change from December 4th, 2023 - commit e422dca in js class "pimcore.element.helpers.gridCellEditor" line 123

Found in Pimcore 11.3.2 with admin-ui-classic-bundle version 1.5.4

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@bk-hitcom bk-hitcom changed the title Custom asset metadata of type object cant be set in asset gridview. Fix: Custom asset metadata of type object cant be set in asset gridview. Oct 1, 2024
@kingjia90 kingjia90 changed the base branch from 1.5 to 1.6 October 1, 2024 08:59
@robertSt7 robertSt7 self-assigned this Oct 4, 2024
@robertSt7 robertSt7 added this to the 1.6.1 milestone Oct 4, 2024
@robertSt7 robertSt7 merged commit 0fda721 into pimcore:1.6 Oct 4, 2024
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
@robertSt7
Copy link
Contributor

@bk-hitcom Thanks for the fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants