Fix remaining duplicate permission issues from #14995 #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@HageMaster3108 As this is a bug fix, could you please change the base branch to 1.5? Thx |
|
@HageMaster3108 Could you please delete the other commits, that are not from you? Thanks |
|
@robertSt7 I think this is ready to merge no? |
|
@HageMaster3108 Thanks for the fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @solverat and @APochmann report there are still scenarios in which the Installer creates duplicate key issues in addPermissions().
These were not fixed by the PR mentioned in #14995 and I have just observed them after updating a legacy pimcore 10 web to 11.3.0
This adds the addPermission() changes suggested by @APochmann in #14995.