Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field type "Table": add button to clone row #559

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

BlackbitDevs
Copy link
Contributor

The field type Table has 2 buttons to "copy" and paste but this cannot be used to copy/clone a row. You can copy the table data but in the paste dialog, the dialog window immediately closes after pasting, so you cannot duplicate a row (only if you copy table content, paste it in an external editor, duplicae the desired row and then use paste button - usability nightmare ;-) ).

This PR adds a button to clone the selected row.

Alternatively / additionally we could change current behaviour of immediately closing the paste dialog box after pasting. But still cloning a row with one button click would be a better UX.

And this PR cleans up the add / delete buttons to be in the same order for columns and rows - before it was

Add column Delete column  Delete row  Add row

Now it is

Add column Delete column  Add row  Delete row

Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.3% Duplication on New Code

See analysis details on SonarCloud

@mcop1 mcop1 self-assigned this Aug 9, 2024
@mcop1 mcop1 added this to the 1.6.0 milestone Aug 9, 2024
@mcop1
Copy link
Contributor

mcop1 commented Aug 9, 2024

I agree on the topic of the closing paste dialog, dont like it at all. Additionally we could ad some tooltips/alt texts for the icons. This should be a separate pr/issue though.
But even with those changes the clone button still makes perfectly sense to me- thanks for the contribution.

@mcop1 mcop1 merged commit 7bf02ca into pimcore:1.x Aug 9, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants