Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldDefinition: Add missing forbidden names #545

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented May 31, 2024

Fatal error: Declaration of Pimcore\Model\DataObject\Test::setClassId(?string $classId) must be compatible with Pimcore\Model\DataObject\Concrete::setClassId($o_classId) in /var/www/html/var/classes/DataObject/Test.php on line 188

See also pimcore/pimcore#17109

@kingjia90 kingjia90 added the Bug label May 31, 2024
@kingjia90 kingjia90 added this to the 1.4.3 milestone May 31, 2024
… ,ClosestParentOfClass, LazyLoadedFieldNames, RelationData to forbidden names
@herbertroth herbertroth modified the milestones: 1.4.3, 1.4.4 Jun 4, 2024
@robertSt7 robertSt7 self-assigned this Jun 7, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.8% Duplication on New Code

See analysis details on SonarCloud

@blankse blankse changed the title FieldDefinition: Add classid to forbidden names FieldDefinition: Add missing forbidden names Jun 11, 2024
@robertSt7 robertSt7 merged commit 8369674 into pimcore:1.4 Jun 14, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
@robertSt7
Copy link
Contributor

@blankse Thanks a lot

@blankse blankse deleted the forbidden_name_classid branch June 14, 2024 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants