Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple simple backend search from admin UI classic bundle #542

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

markus-moser
Copy link
Contributor

@markus-moser markus-moser commented May 29, 2024

Depends on pimcore/pimcore#17105

Resolves #124:

  • Search field is hidden when no search implementation is available
  • Condition related to search_backend_data table is added via event listener instead of adding it directly

@markus-moser markus-moser added this to the 1.5.0 milestone May 29, 2024
@markus-moser markus-moser requested a review from kingjia90 May 29, 2024 14:18
@kingjia90 kingjia90 self-assigned this May 29, 2024
kingjia90 added 2 commits May 31, 2024 12:03
…mple-backend-search-dependency

# Conflicts:
#	public/js/pimcore/object/helpers/gridTabAbstract.js
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@markus-moser markus-moser merged commit f89e48a into 1.x Jun 3, 2024
9 checks passed
@markus-moser markus-moser deleted the remove-simple-backend-search-dependency branch June 3, 2024 07:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remaining hardcoded dependency to SimpleBackendSearchBundle
3 participants