Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimized admin loading to reverse relations #535

Conversation

sl0wlydeadly
Copy link
Contributor

Add "Enable Async Load in Admin" in reverseObjectRelation field

Pimcore Issue: #620

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fashxp
Copy link
Member

fashxp commented Jun 14, 2024

Thx for the PR.

But somehow it doesn't work for me. When activating the async loading, there is no extra request fired when opening a data object.

data object with reverse many-to-many relation (with activated async loading):
image

compare with object with many-to-many relation (with activated async loading):
image

@sl0wlydeadly
Copy link
Contributor Author

Hello and thank you for the response.
I have tried it locally and it worked also for Reverse Object Relation i was able to see the get nice path request.
Is it possible that you tried it without the second change?
image
This is the one change which is supposed to enable the get nice path request for the reverse object relation.

Also there is another PR in pimcore/pimcore which is relevant for the transmission of the data (classname) for the reverse relations to the admin ui:
#620
It is preferable that you test those changes together for the full feature.
If there is something I havent taken into consideration or a change that I should make please notify me and I will look into it :) :)

@fashxp
Copy link
Member

fashxp commented Jun 28, 2024

I had a closer look at this ...
I think it can't work, as there are no changes in the getLayoutEdit function of tags/reverseObjectRelation.js .... which is responsible for rendering the grid ... and thus also loading the nice paths.

You just changed the getLayoutShow function of tags/manyToManyObjectRelation.js ... which is just used when field is in read only mode.

@fashxp
Copy link
Member

fashxp commented Jul 12, 2024

@sl0wlydeadly 🏓

@sl0wlydeadly
Copy link
Contributor Author

@fashxp Hello and thank you for the reply. I will take a closer look at it this weekend. I will probably have to add a check also for the getLayoutEdit, nevertheless i will also test it to see if my changes will be effective.

@fashxp fashxp added this to the 1.6.0 milestone Jul 17, 2024
@fashxp fashxp self-assigned this Jul 17, 2024
@fashxp fashxp merged commit 8e8d4fc into pimcore:1.x Jul 17, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants