Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug, EC; LTS]: Parts of main menu disappear when starting download #522

Conversation

robertSt7
Copy link
Contributor

@robertSt7 robertSt7 commented May 7, 2024

Pimcore version

v11.1.5

Steps to reproduce

Use either demo instance (demo.pimcore.com with light UI or demo.pimcore.fun with classic dark UI) and execute the following steps:

  1. open any Data Object folder
  2. select rows in the grid view
  3. click on "CSV Export"
  4. Click "OK" on Export dialog

Actual Behavior

As soon as you click the OK button and the dialog disappears you can see that thw bottom part of the main menu disappers (seems like it is moved out of the window, at least partly), see the before and after screenshots

before

image

after

image

I just could locate where the problem actual appears (when document.body.appendChild(iframe) is called in pimcore.helpers.download function) but have no idea why:

pimcore.helpers.download = function (url) {
    pimcore.settings.showCloseConfirmation = false;
    window.setTimeout(function () {
        pimcore.settings.showCloseConfirmation = true;
    }, 1000);

    let iframe = document.getElementById('download_helper_iframe');
    if (!iframe) {
        iframe = document.createElement('iframe');
        iframe.setAttribute('id', 'download_helper_iframe');
        document.body.appendChild(iframe);
    }

Expected Behavior

The main menu should not be influenced by doing a download

@robertSt7 robertSt7 added this to the 1.4.3 milestone May 7, 2024
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@robertSt7 robertSt7 merged commit 4f84592 into 1.4 May 7, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
@robertSt7 robertSt7 deleted the 16764-bug-ec-lts-parts-of-main-menu-disappear-when-starting-download branch May 7, 2024 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant