Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Asset upload] Provide translation parameters in correct order #519

Merged

Conversation

BlackbitDevs
Copy link
Contributor

As written in pimcore/pimcore#17005:
Translation for asset_type_change_not_allowed for en is for example

Only assets of same type are allowed here.
[ type of uploaded asset: "%s" | type of existing asset: "%s" ]

but in

'message' => sprintf($translator->trans('asset_type_change_not_allowed', [], 'admin'), $asset->getType(), $newType),
the parameters are provided in reverse order.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alexz707 alexz707 self-assigned this May 3, 2024
@alexz707
Copy link
Contributor

alexz707 commented May 3, 2024

Hello @BlackbitDevs
thanks a lot for finding and fixing this bug!
PR LGTM :)

@alexz707 alexz707 merged commit 4b89a1a into pimcore:1.4 May 3, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
@alexz707 alexz707 added this to the 1.4.3 milestone May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants