Add possibility to make languages not mandatory #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Hamacher <[email protected]>
mcop1
reviewed
Apr 12, 2024
Signed-off-by: Matthias Hamacher <[email protected]>
Signed-off-by: Matthias Hamacher <[email protected]> # Conflicts: # translations/admin_ext.en.yaml
|
I cannot find any problems with the system settings ui. What exactly did break? I had an merge conflict in the translations, that is fixed now, maybe it was that? |
Signed-off-by: Matthias Hamacher <[email protected]>
blankse
reviewed
Apr 15, 2024
It is working now, sorry, seems like it was a problem on my end of the side. |
Co-authored-by: Sebastian Blank <[email protected]>
Signed-off-by: Matthias Hamacher <[email protected]>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves pimcore/pimcore#2958
Additional infos
This uses the logic introduced by pimcore/pimcore#16835 to make languages not mandatory. We add a checkbox in the System Setting where the user can set which languages should be mandatory. In the display logic of the localizedfield fields we update the mandatory state of the fields according to the languages mandatory need.