464 fix filtering objects or variant in grid tab #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
I just notice that when you try to filtering object via grid column the list doesn't update. Perhaps you have some suggestion or you can check better than me. |
kingjia90
reviewed
Mar 18, 2024
Co-authored-by: JiaJia Ji <[email protected]>
|
Now it works great! |
kingjia90
requested changes
Mar 18, 2024
blankse
reviewed
Mar 19, 2024
Co-authored-by: Sebastian Blank <[email protected]>
kingjia90
requested changes
Mar 21, 2024
kingjia90
reviewed
Mar 21, 2024
Co-authored-by: JiaJia Ji <[email protected]>
Co-authored-by: JiaJia Ji <[email protected]>
|
|
All requests have been pushed. Are we now ready to merge? |
|
Yes, it's merged now Grazie ancora per il tuo contributo e ti auguro un buon finesettimana 👍🏻 |
lucfumagalli
deleted the
464-fix-filtering-objects-or-variant-in-grid-tab
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE 464: There is no way to filter objects in grid views based on whether they are of variant type or not
This PR is related to issue #464.
I resolved the issue inserting a select ComboBox in the toolbar of objects grid view. Now you can select what type of objects you can show.