Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup #454 #459

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Followup #454 #459

merged 2 commits into from
Mar 11, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Mar 11, 2024

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@blankse
Copy link
Contributor Author

blankse commented Mar 11, 2024

@kingjia90 The translation key (deprecated) doesn't exist. I created a follow up PR.

@kingjia90 kingjia90 added this to the 1.4.0 milestone Mar 11, 2024
@kingjia90 kingjia90 added the Task label Mar 11, 2024
@kingjia90 kingjia90 merged commit 5ef544a into pimcore:1.x Mar 11, 2024
8 checks passed
@kingjia90
Copy link
Contributor

opss... thank you very much

@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
@blankse blankse deleted the followup_454 branch March 11, 2024 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@blankse @kingjia90