Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide buttons for not editable tables #455

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

APochmann
Copy link
Contributor

If a table is readonly in Edit tab of an object in Admin UI it does not make sense to show inactive buttons for table modifications. This small change hides the buttons in this case for having UI without non usable buttons (see example below)

screenshot without change

image

screenshot after modification

image

If a table is readonly in Edit tab of an object in Admin UI it does not make sense to show inactive buttons for table modifications
@robertSt7 robertSt7 self-assigned this Mar 22, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@robertSt7 robertSt7 added this to the 1.5.0 milestone Mar 22, 2024
@robertSt7 robertSt7 merged commit b8de397 into pimcore:1.x Mar 22, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@robertSt7
Copy link
Contributor

@APochmann Thanks a lot for the improvement

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants