Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail: Don't create cover item with positioning: null #449

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Mar 2, 2024

If you create a cover item for a thumbnail configuration, the positioning is null. When you save it without changing it. You get following error, when you want create this thumbnail:

TypeError: Pimcore\Image\Adapter::cover(): Argument #3 ($orientation) must be of type array|string, null given in /vendor/pimcore/pimcore/lib/Image/Adapter.php:132

See also: pimcore/pimcore#16720

Copy link

sonarqubecloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fashxp
Copy link
Member

fashxp commented Mar 4, 2024

thx very much

@fashxp fashxp merged commit 42e49ee into pimcore:1.3 Mar 4, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
@blankse blankse deleted the patch-1 branch March 4, 2024 08:03
@fashxp fashxp self-assigned this Mar 4, 2024
@fashxp fashxp added this to the 1.3.5 milestone Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants