Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label in string contains operator #441

Conversation

saschabaecher-twocream
Copy link
Contributor

Situation:

  • Open the Grid View in an object folder
  • Open the Grid View configuration
  • Add the "Operator String Contains" operator
  • Change the label of the operator
  • The operator label is not saved! Is always "Operator String Contains"

Expected Behavior:

Adoption of the changed label after saving in the Grid View.

Fix:

Add value from the text field "Label" in the node configAttributes as label.

Copy link

github-actions bot commented Feb 27, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@saschabaecher-twocream
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@saschabaecher-twocream saschabaecher-twocream changed the base branch from 1.x to 1.3 February 28, 2024 11:38
@saschabaecher-twocream saschabaecher-twocream force-pushed the fix-label-in-string-contains-operator branch from f921dd8 to 6c4bdfd Compare February 28, 2024 12:01
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kingjia90 kingjia90 changed the base branch from 1.3 to 1.4 March 12, 2024 16:13
@robertSt7 robertSt7 self-assigned this Mar 22, 2024
@robertSt7 robertSt7 added this to the 1.4.1 milestone Mar 22, 2024
@robertSt7 robertSt7 merged commit 583c797 into pimcore:1.4 Mar 22, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@robertSt7
Copy link
Contributor

@saschabaecher-twocream Thanks for the PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants