Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: quantity values-load base units #415

Merged

Conversation

opreacalina90
Copy link
Contributor

BaseUnits were limited to display the first 25 items, combobox seems to not have an infinite scroll capability, I did a little improvement to display all the baseUnits in the dropdown.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
6.8% Duplication on New Code

See analysis details on SonarCloud

@robertSt7
Copy link
Contributor

@opreacalina90 Could you please rebase this to 1.4? Thanks

@opreacalina90 opreacalina90 changed the base branch from 1.x to 1.4 March 22, 2024 13:14
@opreacalina90 opreacalina90 changed the base branch from 1.4 to 1.x March 22, 2024 13:22
@opreacalina90 opreacalina90 changed the base branch from 1.x to 1.4 April 5, 2024 09:36
@robertSt7 robertSt7 self-assigned this Apr 5, 2024
@robertSt7 robertSt7 added this to the 1.4.1 milestone Apr 5, 2024
@robertSt7 robertSt7 merged commit 89765ce into pimcore:1.4 Apr 5, 2024
5 checks passed
@robertSt7
Copy link
Contributor

@opreacalina90 Thanks for the fix :)

@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants