Refactor export handler from inline into own function

[Corepex]

No description provided.

[mattamon]

LGTM
@kingjia90 wdyt? We would need it in 1.4

[kingjia90]

Not sure how it works on ExtJS, but when setting an id, it would be "global" and unique, right?
Does it work properly when you have 2 or more tab with grids open?

My point is that we may need something like a suffix eg. _grid_2 that identifies the current tab/grid.

[Corepex]

Not sure how it works on ExtJS, but when setting an id, it would be "global" and unique, right? Does it work properly when you have 2 or more tab with grids open?

My point is that we may need something like a suffix eg. _grid_2 that identifies the current tab/grid.

very good point - didn't think of that - i will check it ...

[kingjia90]

By quickly look at the other PR, if we have to apply changes to admin ui classic bundle anyways, shouldn't be easier by refactoring to have this

admin-ui-classic-bundle/public/js/pimcore/object/helpers/gridTabAbstract.js

Lines 316 to 318 in 1976b8f

	pimcore.helpers.exportWarning(exportType, function (settings) {
	this.exportPrepare(settings, exportType);
	}.bind(this));

in an own method and call it (eg. currentGridTab.startExport('csv')) instead of simulating(?) a trigger/click of a button?

It then also overcome the "limit" of the copilot to be only exporting in CSV format. It could be easily extended to XLSX by passing a different exportType parameter.

admin-ui-classic-bundle/public/js/pimcore/object/helpers/gridTabAbstract.js

Line 264 in a5de401

handler: firstButton.handler,

Alternatively just could use getExportButtons() directly

[Corepex]

@kingjia90, thanks for pointing me in the right direction. I moved the export functionality to a separate function (as you mentioned). With that it is now possible to start the export via the currentlyActiveTab ....
This solution feels much more reliable than the id (or class) guessing we had in mind.

[kingjia90]

LGTM, but need to change the PR's title before merging